refactor: use concepts more #5537
Conversation
|
Windows build looks like it's failing to import vcpkg |
|
ahhhhhh outdated android libc++ version https://stackoverflow.com/questions/75942918/expected-concept-name-with-optional-arguments |
|
@OrenAudeles fixed in |
|
nice, android build succeeded and since Windows build hasn't died from vcpkg it'll probably be okay. Once all of the builds finish it's probably okay to call it ready. TBH I'm not familiar enough with |
src/generic_factory.h
Outdated
| template < typename MemberType, typename ReaderType, typename DefaultType = MemberType, | ||
| typename = typename std::enable_if < | ||
| !std::is_constructible<MemberType, const ReaderType &>::value >::type > | ||
| template<typename MemberType, typename ReaderType> requires SupportsReader<MemberType, ReaderType> |
There was a problem hiding this comment.
Does the requires SupportsReader<...> here negate the requirement for the enable_if<is_constructible<...>> in the earlier default value optional implementation?
There was a problem hiding this comment.
err wait no i don't think so, lemme write a fix real quick
There was a problem hiding this comment.
done in a23cd22 (#5537), this one can be trusted because it's auto-migrated with clang-tidy. also #5540 because std::same_as is removed, preventing this error from happening
scarf005
force-pushed
the
refactor/use-concepts
branch
from
d8ba955
to
a23cd22
Compare
Checklist
Required
mainso it won't cause conflict when updatingmainbranch later.Purpose of change
followup to #5514; concept is easier to understand than SNIFAE, let's use them more!
Describe the solution
check individual commits for details.
Describe alternatives you've considered
use less overloading trickery and just use different name for
optional?Testing
compiled in my machine (tm) but need to check if the concepts translation is correct because they're done 100% manually
Additional context
i'm dumdum and found this after i've done it manually: https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-constraints.html